Skip to content

Commit d6c66cd

Browse files
Yunlong SongJaegeuk Kim
authored andcommitted
f2fs: fix count of seg_freed to make sec_freed correct
When sbi->segs_per_sec > 1, and if some segno has 0 valid blocks before gc starts, do_garbage_collect will skip counting seg_freed++, and this will cause seg_freed < sbi->segs_per_sec and finally skip sec_freed++. Signed-off-by: Yunlong Song <yunlong.song@huawei.com> Signed-off-by: Chao Yu <yuchao0@huawei.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent a8075dc commit d6c66cd

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

fs/f2fs/gc.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1140,9 +1140,9 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
11401140
GET_SUM_BLOCK(sbi, segno));
11411141
f2fs_put_page(sum_page, 0);
11421142

1143-
if (get_valid_blocks(sbi, segno, false) == 0 ||
1144-
!PageUptodate(sum_page) ||
1145-
unlikely(f2fs_cp_error(sbi)))
1143+
if (get_valid_blocks(sbi, segno, false) == 0)
1144+
goto freed;
1145+
if (!PageUptodate(sum_page) || unlikely(f2fs_cp_error(sbi)))
11461146
goto next;
11471147

11481148
sum = page_address(sum_page);
@@ -1170,6 +1170,7 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
11701170

11711171
stat_inc_seg_count(sbi, type, gc_type);
11721172

1173+
freed:
11731174
if (gc_type == FG_GC &&
11741175
get_valid_blocks(sbi, segno, false) == 0)
11751176
seg_freed++;

0 commit comments

Comments
 (0)