Btrfs: remove always true check in unlock_up

liubogithub · kdave · commit d80bb3f905cc · 2018-05-30T16:46:51.000+02:00
As unlock_up() is written as

for () {
   if (!path-&gt;locks[i])
       break;
   ...
   if (... &amp;&amp; path-&gt;locks[i]) {
   }
}

Apparently, @path-&gt;locks[i] is always true at this 'if'.

Signed-off-by: Liu Bo &lt;bo.liu@linux.alibaba.com&gt;
Reviewed-by: David Sterba &lt;dsterba@suse.com&gt;
Reviewed-by: Qu Wenruo &lt;wqu@suse.com&gt;
Signed-off-by: David Sterba &lt;dsterba@suse.com&gt;
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
@@ -2330,7 +2330,7 @@ static noinline void unlock_up(struct btrfs_path *path, int level,
 			no_skips = 1;
 
 		t = path->nodes[i];
-		if (i >= lowest_unlock && i > skip_level && path->locks[i]) {
+		if (i >= lowest_unlock && i > skip_level) {
 			btrfs_tree_unlock_rw(t, path->locks[i]);
 			path->locks[i] = 0;
 			if (write_lock_level &&
