Skip to content

Commit d81be4f

Browse files
committed
drm/i915: Remove intel_panel_detect()
With neither LVDS or eDP no longer using intel_panel_detect() we can kill it, and the accompanying modparam. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180717174216.22252-3-ville.syrjala@linux.intel.com Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent b93b41a commit d81be4f

File tree

4 files changed

+0
-26
lines changed

4 files changed

+0
-26
lines changed

drivers/gpu/drm/i915/i915_params.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@ i915_param_named(modeset, int, 0400,
4444
"Use kernel modesetting [KMS] (0=disable, "
4545
"1=on, -1=force vga console preference [default])");
4646

47-
i915_param_named_unsafe(panel_ignore_lid, int, 0600,
48-
"Override lid status (0=autodetect, 1=autodetect disabled [default], "
49-
"-1=force lid closed, -2=force lid open)");
50-
5147
i915_param_named_unsafe(enable_dc, int, 0400,
5248
"Enable power-saving display C-states. "
5349
"(-1=auto [default]; 0=disable; 1=up to DC5; 2=up to DC6)");

drivers/gpu/drm/i915/i915_params.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ struct drm_printer;
3636
#define I915_PARAMS_FOR_EACH(param) \
3737
param(char *, vbt_firmware, NULL) \
3838
param(int, modeset, -1) \
39-
param(int, panel_ignore_lid, 1) \
4039
param(int, lvds_channel_mode, 0) \
4140
param(int, panel_use_ssc, -1) \
4241
param(int, vbt_sdvo_panel_type, -1) \

drivers/gpu/drm/i915/intel_drv.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1889,7 +1889,6 @@ void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
18891889
const struct drm_connector_state *conn_state);
18901890
void intel_panel_disable_backlight(const struct drm_connector_state *old_conn_state);
18911891
void intel_panel_destroy_backlight(struct drm_connector *connector);
1892-
enum drm_connector_status intel_panel_detect(struct drm_i915_private *dev_priv);
18931892
extern struct drm_display_mode *intel_find_panel_downclock(
18941893
struct drm_i915_private *dev_priv,
18951894
struct drm_display_mode *fixed_mode,

drivers/gpu/drm/i915/intel_panel.c

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -375,26 +375,6 @@ void intel_gmch_panel_fitting(struct intel_crtc *intel_crtc,
375375
pipe_config->gmch_pfit.lvds_border_bits = border;
376376
}
377377

378-
enum drm_connector_status
379-
intel_panel_detect(struct drm_i915_private *dev_priv)
380-
{
381-
/* Assume that the BIOS does not lie through the OpRegion... */
382-
if (!i915_modparams.panel_ignore_lid && dev_priv->opregion.lid_state) {
383-
return *dev_priv->opregion.lid_state & 0x1 ?
384-
connector_status_connected :
385-
connector_status_disconnected;
386-
}
387-
388-
switch (i915_modparams.panel_ignore_lid) {
389-
case -2:
390-
return connector_status_connected;
391-
case -1:
392-
return connector_status_disconnected;
393-
default:
394-
return connector_status_unknown;
395-
}
396-
}
397-
398378
/**
399379
* scale - scale values from one range to another
400380
* @source_val: value in range [@source_min..@source_max]

0 commit comments

Comments
 (0)