PM / Domains: Constify genpd pointer

krzk · rafaeljw · commit d8600c8b0cd1 · 2017-06-28T00:24:21.000+02:00
Mark pointer to struct generic_pm_domain const (either passed in
argument or used localy in a function), whenever it is not modifed by
the function itself.

Signed-off-by: Krzysztof Kozlowski &lt;krzk@kernel.org&gt;
Acked-by: Ulf Hansson &lt;ulf.hansson@linaro.org&gt;
Signed-off-by: Rafael J. Wysocki &lt;rafael.j.wysocki@intel.com&gt;
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
@@ -126,7 +126,7 @@ static const struct genpd_lock_ops genpd_spin_ops = {
 #define genpd_is_always_on(genpd)	(genpd->flags & GENPD_FLAG_ALWAYS_ON)
 
 static inline bool irq_safe_dev_in_no_sleep_domain(struct device *dev,
-		struct generic_pm_domain *genpd)
+		const struct generic_pm_domain *genpd)
 {
 	bool ret;
 
@@ -181,12 +181,14 @@ static struct generic_pm_domain *dev_to_genpd(struct device *dev)
 	return pd_to_genpd(dev->pm_domain);
 }
 
-static int genpd_stop_dev(struct generic_pm_domain *genpd, struct device *dev)
+static int genpd_stop_dev(const struct generic_pm_domain *genpd,
+			  struct device *dev)
 {
 	return GENPD_DEV_CALLBACK(genpd, int, stop, dev);
 }
 
-static int genpd_start_dev(struct generic_pm_domain *genpd, struct device *dev)
+static int genpd_start_dev(const struct generic_pm_domain *genpd,
+			   struct device *dev)
 {
 	return GENPD_DEV_CALLBACK(genpd, int, start, dev);
 }
@@ -738,7 +740,7 @@ static bool pm_genpd_present(const struct generic_pm_domain *genpd)
 
 #ifdef CONFIG_PM_SLEEP
 
-static bool genpd_dev_active_wakeup(struct generic_pm_domain *genpd,
+static bool genpd_dev_active_wakeup(const struct generic_pm_domain *genpd,
 				    struct device *dev)
 {
 	return GENPD_DEV_CALLBACK(genpd, bool, active_wakeup, dev);
@@ -840,7 +842,8 @@ static void genpd_sync_power_on(struct generic_pm_domain *genpd, bool use_lock,
  * signal remote wakeup from the system's working state as needed by runtime PM.
  * Return 'true' in either of the above cases.
  */
-static bool resume_needed(struct device *dev, struct generic_pm_domain *genpd)
+static bool resume_needed(struct device *dev,
+			  const struct generic_pm_domain *genpd)
 {
 	bool active_wakeup;
 
@@ -975,7 +978,7 @@ static int pm_genpd_resume_noirq(struct device *dev)
  */
 static int pm_genpd_freeze_noirq(struct device *dev)
 {
-	struct generic_pm_domain *genpd;
+	const struct generic_pm_domain *genpd;
 	int ret = 0;
 
 	dev_dbg(dev, "%s()\n", __func__);
@@ -999,7 +1002,7 @@ static int pm_genpd_freeze_noirq(struct device *dev)
  */
 static int pm_genpd_thaw_noirq(struct device *dev)
 {
-	struct generic_pm_domain *genpd;
+	const struct generic_pm_domain *genpd;
 	int ret = 0;
 
 	dev_dbg(dev, "%s()\n", __func__);

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ static const struct genpd_lock_ops genpd_spin_ops = {`
`126`	`126`	`#define genpd_is_always_on(genpd) (genpd->flags & GENPD_FLAG_ALWAYS_ON)`
`127`	`127`
`128`	`128`	`static inline bool irq_safe_dev_in_no_sleep_domain(struct device *dev,`
`129`		`- struct generic_pm_domain *genpd)`
	`129`	`+ const struct generic_pm_domain *genpd)`
`130`	`130`	`{`
`131`	`131`	`bool ret;`
`132`	`132`
`@@ -181,12 +181,14 @@ static struct generic_pm_domain dev_to_genpd(struct device dev)`
`181`	`181`	`return pd_to_genpd(dev->pm_domain);`
`182`	`182`	`}`
`183`	`183`
`184`		`-static int genpd_stop_dev(struct generic_pm_domain genpd, struct device dev)`
	`184`	`+static int genpd_stop_dev(const struct generic_pm_domain *genpd,`
	`185`	`+ struct device *dev)`
`185`	`186`	`{`
`186`	`187`	`return GENPD_DEV_CALLBACK(genpd, int, stop, dev);`
`187`	`188`	`}`
`188`	`189`
`189`		`-static int genpd_start_dev(struct generic_pm_domain genpd, struct device dev)`
	`190`	`+static int genpd_start_dev(const struct generic_pm_domain *genpd,`
	`191`	`+ struct device *dev)`
`190`	`192`	`{`
`191`	`193`	`return GENPD_DEV_CALLBACK(genpd, int, start, dev);`
`192`	`194`	`}`
`@@ -738,7 +740,7 @@ static bool pm_genpd_present(const struct generic_pm_domain *genpd)`
`738`	`740`
`739`	`741`	`#ifdef CONFIG_PM_SLEEP`
`740`	`742`
`741`		`-static bool genpd_dev_active_wakeup(struct generic_pm_domain *genpd,`
	`743`	`+static bool genpd_dev_active_wakeup(const struct generic_pm_domain *genpd,`
`742`	`744`	`struct device *dev)`
`743`	`745`	`{`
`744`	`746`	`return GENPD_DEV_CALLBACK(genpd, bool, active_wakeup, dev);`
`@@ -840,7 +842,8 @@ static void genpd_sync_power_on(struct generic_pm_domain *genpd, bool use_lock,`
`840`	`842`	`* signal remote wakeup from the system's working state as needed by runtime PM.`
`841`	`843`	`* Return 'true' in either of the above cases.`
`842`	`844`	`*/`
`843`		`-static bool resume_needed(struct device dev, struct generic_pm_domain genpd)`
	`845`	`+static bool resume_needed(struct device *dev,`
	`846`	`+ const struct generic_pm_domain *genpd)`
`844`	`847`	`{`
`845`	`848`	`bool active_wakeup;`
`846`	`849`
`@@ -975,7 +978,7 @@ static int pm_genpd_resume_noirq(struct device *dev)`
`975`	`978`	`*/`
`976`	`979`	`static int pm_genpd_freeze_noirq(struct device *dev)`
`977`	`980`	`{`
`978`		`- struct generic_pm_domain *genpd;`
	`981`	`+ const struct generic_pm_domain *genpd;`
`979`	`982`	`int ret = 0;`
`980`	`983`
`981`	`984`	`dev_dbg(dev, "%s()\n", __func__);`
`@@ -999,7 +1002,7 @@ static int pm_genpd_freeze_noirq(struct device *dev)`
`999`	`1002`	`*/`
`1000`	`1003`	`static int pm_genpd_thaw_noirq(struct device *dev)`
`1001`	`1004`	`{`
`1002`		`- struct generic_pm_domain *genpd;`
	`1005`	`+ const struct generic_pm_domain *genpd;`
`1003`	`1006`	`int ret = 0;`
`1004`	`1007`
`1005`	`1008`	`dev_dbg(dev, "%s()\n", __func__);`