Revert "scsi: libfc: Add WARN_ON() when deleting rports"

rosslagerwall · martinkpetersen · commit d8f6382a7d02 · 2019-02-04T22:17:33.000-05:00
This reverts commit bbc0f8b. It added a warning whose intent was to check whether the rport was still linked into the peer list. It doesn't work as intended and gives false positive warnings for two reasons: 1) If the rport is never linked into the peer list it will not be considered empty since the list_head is never initialized. 2) If the rport is deleted from the peer list using list_del_rcu(), then the list_head is in an undefined state and it is not considered empty. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Reviewed-by: Hannes Reinecke <hare@suse.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
@@ -184,7 +184,6 @@ void fc_rport_destroy(struct kref *kref)
 	struct fc_rport_priv *rdata;
 
 	rdata = container_of(kref, struct fc_rport_priv, kref);
-	WARN_ON(!list_empty(&rdata->peers));
 	kfree_rcu(rdata, rcu);
 }
 EXPORT_SYMBOL(fc_rport_destroy);

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,6 @@ void fc_rport_destroy(struct kref *kref)`
`184`	`184`	`struct fc_rport_priv *rdata;`
`185`	`185`
`186`	`186`	`rdata = container_of(kref, struct fc_rport_priv, kref);`
`187`		`- WARN_ON(!list_empty(&rdata->peers));`
`188`	`187`	`kfree_rcu(rdata, rcu);`
`189`	`188`	`}`
`190`	`189`	`EXPORT_SYMBOL(fc_rport_destroy);`