KVM: arm/arm64: vgic-its: Make attribute accessors static

YueHaibing · Marc Zyngier · commit d9ea27a33048 · 2019-03-20T17:33:41.000Z
Fix sparse warnings:

arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-its.c:1732:5: warning:
 symbol 'vgic_its_has_attr_regs' was not declared. Should it be static?
arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-its.c:1753:5: warning:
 symbol 'vgic_its_attr_regs_access' was not declared. Should it be static?

Signed-off-by: YueHaibing &lt;yuehaibing@huawei.com&gt;
[maz: fixed subject]
Signed-off-by: Marc Zyngier &lt;marc.zyngier@arm.com&gt;
diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
@@ -1736,8 +1736,8 @@ static void vgic_its_destroy(struct kvm_device *kvm_dev)
 	kfree(its);
 }
 
-int vgic_its_has_attr_regs(struct kvm_device *dev,
-			   struct kvm_device_attr *attr)
+static int vgic_its_has_attr_regs(struct kvm_device *dev,
+				  struct kvm_device_attr *attr)
 {
 	const struct vgic_register_region *region;
 	gpa_t offset = attr->attr;
@@ -1757,9 +1757,9 @@ int vgic_its_has_attr_regs(struct kvm_device *dev,
 	return 0;
 }
 
-int vgic_its_attr_regs_access(struct kvm_device *dev,
-			      struct kvm_device_attr *attr,
-			      u64 *reg, bool is_write)
+static int vgic_its_attr_regs_access(struct kvm_device *dev,
+				     struct kvm_device_attr *attr,
+				     u64 *reg, bool is_write)
 {
 	const struct vgic_register_region *region;
 	struct vgic_its *its;

Original file line number	Diff line number	Diff line change
`@@ -1736,8 +1736,8 @@ static void vgic_its_destroy(struct kvm_device *kvm_dev)`
`1736`	`1736`	`kfree(its);`
`1737`	`1737`	`}`
`1738`	`1738`
`1739`		`-int vgic_its_has_attr_regs(struct kvm_device *dev,`
`1740`		`- struct kvm_device_attr *attr)`
	`1739`	`+static int vgic_its_has_attr_regs(struct kvm_device *dev,`
	`1740`	`+ struct kvm_device_attr *attr)`
`1741`	`1741`	`{`
`1742`	`1742`	`const struct vgic_register_region *region;`
`1743`	`1743`	`gpa_t offset = attr->attr;`
`@@ -1757,9 +1757,9 @@ int vgic_its_has_attr_regs(struct kvm_device *dev,`
`1757`	`1757`	`return 0;`
`1758`	`1758`	`}`
`1759`	`1759`
`1760`		`-int vgic_its_attr_regs_access(struct kvm_device *dev,`
`1761`		`- struct kvm_device_attr *attr,`
`1762`		`- u64 *reg, bool is_write)`
	`1760`	`+static int vgic_its_attr_regs_access(struct kvm_device *dev,`
	`1761`	`+ struct kvm_device_attr *attr,`
	`1762`	`+ u64 *reg, bool is_write)`
`1763`	`1763`	`{`
`1764`	`1764`	`const struct vgic_register_region *region;`
`1765`	`1765`	`struct vgic_its *its;`