Skip to content

Commit db1ad33

Browse files
Paul Gortmakergregkh
authored andcommitted
drivers/staging: make android sw_sync.c explicitly non-modular
The Kconfig currently controlling compilation of this code is: staging/android/Kconfig:config SW_SYNC staging/android/Kconfig: bool "Software synchronization objects" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Cc: "Arve Hjønnevåg" <arve@android.com> Cc: Riley Andrews <riandrews@android.com> Cc: devel@driverdev.osuosl.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 1295059 commit db1ad33

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

drivers/staging/android/sw_sync.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
*/
1616

1717
#include <linux/kernel.h>
18+
#include <linux/init.h>
1819
#include <linux/export.h>
1920
#include <linux/file.h>
2021
#include <linux/fs.h>
2122
#include <linux/miscdevice.h>
22-
#include <linux/module.h>
2323
#include <linux/syscalls.h>
2424
#include <linux/uaccess.h>
2525

@@ -255,13 +255,6 @@ static int __init sw_sync_device_init(void)
255255
{
256256
return misc_register(&sw_sync_dev);
257257
}
258-
259-
static void __exit sw_sync_device_remove(void)
260-
{
261-
misc_deregister(&sw_sync_dev);
262-
}
263-
264-
module_init(sw_sync_device_init);
265-
module_exit(sw_sync_device_remove);
258+
device_initcall(sw_sync_device_init);
266259

267260
#endif /* CONFIG_SW_SYNC_USER */

0 commit comments

Comments
 (0)