checkpatch: fix UNNECESSARY_KERN_LEVEL false positive

bonzini · torvalds · commit dcaf11236536 · 2015-02-13T21:21:39.000-08:00
KERN_&lt;LEVEL&gt; is never redundant with printk_ratelimited or printk_once.
(Except perhaps in the sense that you could use e.g.  pr_err_ratelimited
or pr_err_once, but that would apply to printk as well).

Signed-off-by: Paolo Bonzini &lt;pbonzini@redhat.com&gt;
Cc: Andy Whitcroft &lt;apw@canonical.com&gt;
Acked-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
@@ -4547,7 +4547,7 @@ sub process {
 		}
 
 # check for logging functions with KERN_<LEVEL>
-		if ($line !~ /printk\s*\(/ &&
+		if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&
 		    $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
 			my $level = $1;
 			if (WARN("UNNECESSARY_KERN_LEVEL",

Original file line number	Diff line number	Diff line change
`@@ -4547,7 +4547,7 @@ sub process {`
`4547`	`4547`	`}`
`4548`	`4548`
`4549`	`4549`	`# check for logging functions with KERN_<LEVEL>`
`4550`		`- if ($line !~ /printk\s*\(/ &&`
	`4550`	`+ if ($line !~ /printk(?:_ratelimited\|_once)?\s*\(/ &&`
`4551`	`4551`	`$line =~ /\b$logFunctions\s\(.\b(KERN_[A-Z]+)\b/) {`
`4552`	`4552`	`my $level = $1;`
`4553`	`4553`	`if (WARN("UNNECESSARY_KERN_LEVEL",`