Input: adi - remove an unnecessary check

elfring · dtor · commit de3748f66f21 · 2015-02-11T23:07:13.000-08:00
The input_free_device() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring &lt;elfring@users.sourceforge.net&gt;
Signed-off-by: Dmitry Torokhov &lt;dmitry.torokhov@gmail.com&gt;
diff --git a/drivers/input/joystick/adi.c b/drivers/input/joystick/adi.c
@@ -535,8 +535,7 @@ static int adi_connect(struct gameport *gameport, struct gameport_driver *drv)
 		}
 	}
  fail2:	for (i = 0; i < 2; i++)
-		if (port->adi[i].dev)
-			input_free_device(port->adi[i].dev);
+		input_free_device(port->adi[i].dev);
 	gameport_close(gameport);
  fail1:	gameport_set_drvdata(gameport, NULL);
 	kfree(port);

Original file line number	Diff line number	Diff line change
`@@ -535,8 +535,7 @@ static int adi_connect(struct gameport gameport, struct gameport_driver drv)`
`535`	`535`	`}`
`536`	`536`	`}`
`537`	`537`	`fail2: for (i = 0; i < 2; i++)`
`538`		`- if (port->adi[i].dev)`
`539`		`- input_free_device(port->adi[i].dev);`
	`538`	`+ input_free_device(port->adi[i].dev);`
`540`	`539`	`gameport_close(gameport);`
`541`	`540`	`fail1: gameport_set_drvdata(gameport, NULL);`
`542`	`541`	`kfree(port);`