wifi: wilc1000: fix potential memory leak in wilc_mac_xmit()

Zhang Changzhong · Kalle Valo · commit deb962ec9e1c · 2022-12-22T18:05:57.000+02:00
The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add dev_kfree_skb() to fix it. Compile tested only. Fixes: c5c77ba ("staging: wilc1000: Add SDIO/SPI 802.11 driver") Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com
diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c
@@ -730,6 +730,7 @@ netdev_tx_t wilc_mac_xmit(struct sk_buff *skb, struct net_device *ndev)
 
 	if (skb->dev != ndev) {
 		netdev_err(ndev, "Packet not destined to this device\n");
+		dev_kfree_skb(skb);
 		return NETDEV_TX_OK;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -730,6 +730,7 @@ netdev_tx_t wilc_mac_xmit(struct sk_buff skb, struct net_device ndev)`
`730`	`730`
`731`	`731`	`if (skb->dev != ndev) {`
`732`	`732`	`netdev_err(ndev, "Packet not destined to this device\n");`
	`733`	`+ dev_kfree_skb(skb);`
`733`	`734`	`return NETDEV_TX_OK;`
`734`	`735`	`}`
`735`	`736`