ipv4: loopback device: ignore value changes after device is upped

jpirko · davem330 · commit dfd1582d1e4d · 2014-01-07T15:55:17.000-05:00
When lo is brought up, new ifa is created. Then, devconf and neigh values
bitfield should be set so later changes of default values would not
affect lo values.

Note that the same behaviour is in ipv6. Also note that this is likely
not an issue in many distros (for example Fedora 19) because userspace
sets address to lo manually before bringing it up.

Signed-off-by: Jiri Pirko &lt;jiri@resnulli.us&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
@@ -1385,6 +1385,8 @@ static int inetdev_event(struct notifier_block *this, unsigned long event,
 				memcpy(ifa->ifa_label, dev->name, IFNAMSIZ);
 				set_ifa_lifetime(ifa, INFINITY_LIFE_TIME,
 						 INFINITY_LIFE_TIME);
+				ipv4_devconf_setall(in_dev);
+				neigh_parms_data_state_setall(in_dev->arp_parms);
 				inet_insert_ifa(ifa);
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -1385,6 +1385,8 @@ static int inetdev_event(struct notifier_block *this, unsigned long event,`
`1385`	`1385`	`memcpy(ifa->ifa_label, dev->name, IFNAMSIZ);`
`1386`	`1386`	`set_ifa_lifetime(ifa, INFINITY_LIFE_TIME,`
`1387`	`1387`	`INFINITY_LIFE_TIME);`
	`1388`	`+ ipv4_devconf_setall(in_dev);`
	`1389`	`+ neigh_parms_data_state_setall(in_dev->arp_parms);`
`1388`	`1390`	`inet_insert_ifa(ifa);`
`1389`	`1391`	`}`
`1390`	`1392`	`}`