mtd: cfi_cmdset_0002: Change write buffer to check correct value

tokunori · Boris Brezillon · commit dfeae1073583 · 2018-05-30T21:38:19.000+02:00
For the word write it is checked if the chip has the correct value.
But it is not checked for the write buffer as only checked if ready.
To make sure for the write buffer change to check the value.

It is enough as this patch is only checking the last written word.
Since it is described by data sheets to check the operation status.

Signed-off-by: Tokunori Ikegami &lt;ikegami@allied-telesis.co.jp&gt;
Reviewed-by: Joakim Tjernlund &lt;Joakim.Tjernlund@infinera.com&gt;
Cc: Chris Packham &lt;chris.packham@alliedtelesis.co.nz&gt;
Cc: Brian Norris &lt;computersforpeace@gmail.com&gt;
Cc: David Woodhouse &lt;dwmw2@infradead.org&gt;
Cc: Boris Brezillon &lt;boris.brezillon@free-electrons.com&gt;
Cc: Marek Vasut &lt;marek.vasut@gmail.com&gt;
Cc: Richard Weinberger &lt;richard@nod.at&gt;
Cc: Cyrille Pitchen &lt;cyrille.pitchen@wedev4u.fr&gt;
Cc: linux-mtd@lists.infradead.org
Cc: stable@vger.kernel.org
Signed-off-by: Boris Brezillon &lt;boris.brezillon@bootlin.com&gt;
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1879,7 +1879,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
 		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
 			break;
 
-		if (chip_ready(map, adr)) {
+		if (chip_good(map, adr, datum)) {
 			xip_enable(map, chip, adr);
 			goto op_done;
 		}

Original file line number	Diff line number	Diff line change
`@@ -1879,7 +1879,7 @@ static int __xipram do_write_buffer(struct map_info map, struct flchip chip,`
`1879`	`1879`	`if (time_after(jiffies, timeo) && !chip_ready(map, adr))`
`1880`	`1880`	`break;`
`1881`	`1881`
`1882`		`- if (chip_ready(map, adr)) {`
	`1882`	`+ if (chip_good(map, adr, datum)) {`
`1883`	`1883`	`xip_enable(map, chip, adr);`
`1884`	`1884`	`goto op_done;`
`1885`	`1885`	`}`