Skip to content

Commit e026646

Browse files
William Breathitt Graylinusw
authored andcommitted
gpio: pcie-idio-24: Fix off-by-one error in get_multiple loop
The PCIe-IDIO-24 features 8 bits of TTL GPIO which may be configured for output or input. This patch fixes an off-by-one error in the loop conditional for the get_multiple callback so that the TTL GPIO are handled. Fixes: ca37081 ("gpio: pcie-idio-24: Implement get_multiple/set_multiple callbacks") Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 304440a commit e026646

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpio/gpio-pcie-idio-24.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ static int idio_24_gpio_get_multiple(struct gpio_chip *chip,
217217
bitmap_zero(bits, chip->ngpio);
218218

219219
/* get bits are evaluated a gpio port register at a time */
220-
for (i = 0; i < ARRAY_SIZE(ports); i++) {
220+
for (i = 0; i < ARRAY_SIZE(ports) + 1; i++) {
221221
/* gpio offset in bits array */
222222
bits_offset = i * gpio_reg_size;
223223

0 commit comments

Comments
 (0)