drm/vmwgfx: remove redundant return ret statement

Colin Ian King · thomashvmw · commit e06d45d8c165 · 2018-12-12T12:01:05.000+01:00
The return statement is redundant as there is a return statement
immediately before it so we have dead code that can be removed.
Also remove the unused declaration of ret.

Detected by CoverityScan, CID#1473793 ("Structurally dead code")

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Reviewed-by: Thomas Hellstrom &lt;thellstrom@vmware.com&gt;
Signed-off-by: Thomas Hellstrom &lt;thellstrom@vmware.com&gt;
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -1738,7 +1738,6 @@ static int vmw_cmd_check_define_gmrfb(struct vmw_private *dev_priv,
 				      void *buf)
 {
 	struct vmw_buffer_object *vmw_bo;
-	int ret;
 
 	struct {
 		uint32_t header;
@@ -1748,7 +1747,6 @@ static int vmw_cmd_check_define_gmrfb(struct vmw_private *dev_priv,
 	return vmw_translate_guest_ptr(dev_priv, sw_context,
 				       &cmd->body.ptr,
 				       &vmw_bo);
-	return ret;
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -1738,7 +1738,6 @@ static int vmw_cmd_check_define_gmrfb(struct vmw_private *dev_priv,`
`1738`	`1738`	`void *buf)`
`1739`	`1739`	`{`
`1740`	`1740`	`struct vmw_buffer_object *vmw_bo;`
`1741`		`- int ret;`
`1742`	`1741`
`1743`	`1742`	`struct {`
`1744`	`1743`	`uint32_t header;`
`@@ -1748,7 +1747,6 @@ static int vmw_cmd_check_define_gmrfb(struct vmw_private *dev_priv,`
`1748`	`1747`	`return vmw_translate_guest_ptr(dev_priv, sw_context,`
`1749`	`1748`	`&cmd->body.ptr,`
`1750`	`1749`	`&vmw_bo);`
`1751`		`- return ret;`
`1752`	`1750`	`}`
`1753`	`1751`
`1754`	`1752`