Skip to content

Commit e0d4229

Browse files
arndbjacek-anaszewski
authored andcommitted
leds: blinkm: avoid uninitialized data use
gcc-8 reports missing error handling in blinkm_detect, when blinkm() fails, tmpargs[] is uninitialized: drivers/leds/leds-blinkm.c: In function 'blinkm_detect': drivers/leds/leds-blinkm.c:555:6: error: 'tmpargs' may be used uninitialized in this function [-Werror=maybe-uninitialized] This adds a missing error checks. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
1 parent a72d3b5 commit e0d4229

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/leds/leds-blinkm.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -549,8 +549,12 @@ static int blinkm_detect(struct i2c_client *client, struct i2c_board_info *info)
549549
/* make sure the blinkM is balanced (read/writes) */
550550
while (count > 0) {
551551
ret = blinkm_write(client, BLM_GET_ADDR, NULL);
552+
if (ret)
553+
return ret;
552554
usleep_range(5000, 10000);
553555
ret = blinkm_read(client, BLM_GET_ADDR, tmpargs);
556+
if (ret)
557+
return ret;
554558
usleep_range(5000, 10000);
555559
if (tmpargs[0] == 0x09)
556560
count = 0;

0 commit comments

Comments
 (0)