Skip to content

Commit e12ba23

Browse files
Aisheng DongMarc Zyngier
authored andcommitted
dt-binding: irq: imx-irqsteer: Use irq number instead of group number
Not all 64 interrupts may be used in one group. e.g. most irqsteer in imx8qxp and imx8qm subsystems supports only 32 interrupts. As the IP integration parameters are Channel number and interrupts number, let's use fsl,irqs-num to represents how many interrupts supported by this irqsteer channel. Note this will break the compatibility of old binding. As the original fsl,irq-groups was born out of a misunderstanding of the HW config options and we are not aware of any users of the current binding. And the old binding was just published in recent months, so it's worth to change now to avoid confusing in the future. Cc: Rob Herring <robh+dt@kernel.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: devicetree@vger.kernel.org Reviewed-by: Lucas Stach <l.stach@pengutronix.de> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
1 parent 3351788 commit e12ba23

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ Required properties:
1616
- #interrupt-cells: Specifies the number of cells needed to encode an
1717
interrupt source. The value must be 1.
1818
- fsl,channel: The output channel that all input IRQs should be steered into.
19-
- fsl,irq-groups: Number of IRQ groups managed by this controller instance.
20-
Each group manages 64 input interrupts.
19+
- fsl,num-irqs: Number of input interrupts of this channel.
20+
Should be multiple of 32 input interrupts and up to 512 interrupts.
2121

2222
Example:
2323

@@ -28,7 +28,7 @@ Example:
2828
clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
2929
clock-names = "ipg";
3030
fsl,channel = <0>;
31-
fsl,irq-groups = <1>;
31+
fsl,num-irqs = <64>;
3232
interrupt-controller;
3333
#interrupt-cells = <1>;
3434
};

0 commit comments

Comments
 (0)