Skip to content

Commit e3c6cf6

Browse files
fujitatorvalds
authored andcommitted
uml: fix build
Fix a build error introduced by d6d1b65 ("param: simple locking for sysfs-writable charp parameters"). CC arch/um/kernel/trap.o arch/um/drivers/hostaudio_kern.c: In function 'hostaudio_open': arch/um/drivers/hostaudio_kern.c:204: error: '__param_dsp' undeclared (first use in this function) arch/um/drivers/hostaudio_kern.c:204: error: (Each undeclared identifier is reported only once arch/um/drivers/hostaudio_kern.c:204: error: for each function it appears in.) arch/um/drivers/hostaudio_kern.c: In function 'hostmixer_open_mixdev': arch/um/drivers/hostaudio_kern.c:265: error: '__param_mixer' undeclared (first use in this function) arch/um/drivers/hostaudio_kern.c:272: error: '__param_dsp' undeclared (first use in this function) Reported-by: Toralf Förster <toralf.foerster@gmx.de> Tested-by: Toralf Förster <toralf.foerster@gmx.de> Cc: Rusty Russell <rusty@rustcorp.com.au> Cc: Takashi Iwai <tiwai@suse.de> Cc: Jeff Dike <jdike@addtoit.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent a9febbb commit e3c6cf6

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

arch/um/drivers/hostaudio_kern.c

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@ static char *mixer = HOSTAUDIO_DEV_MIXER;
4040
" This is used to specify the host mixer device to the hostaudio driver.\n"\
4141
" The default is \"" HOSTAUDIO_DEV_MIXER "\".\n\n"
4242

43+
module_param(dsp, charp, 0644);
44+
MODULE_PARM_DESC(dsp, DSP_HELP);
45+
module_param(mixer, charp, 0644);
46+
MODULE_PARM_DESC(mixer, MIXER_HELP);
47+
4348
#ifndef MODULE
4449
static int set_dsp(char *name, int *add)
4550
{
@@ -56,15 +61,6 @@ static int set_mixer(char *name, int *add)
5661
}
5762

5863
__uml_setup("mixer=", set_mixer, "mixer=<mixer device>\n" MIXER_HELP);
59-
60-
#else /*MODULE*/
61-
62-
module_param(dsp, charp, 0644);
63-
MODULE_PARM_DESC(dsp, DSP_HELP);
64-
65-
module_param(mixer, charp, 0644);
66-
MODULE_PARM_DESC(mixer, MIXER_HELP);
67-
6864
#endif
6965

7066
/* /dev/dsp file operations */

0 commit comments

Comments
 (0)