cxgb4: fix coccinelle warnings

Hariprasad Shenai · davem330 · commit e3d50738e59a · 2015-03-10T13:42:00.000-04:00
Commit 16e4762 ("cxgb4: Add new scheme to update T4/T5 firmware") introduced below coccinelle warning. >> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:994:2-8: Replace memcpy with struct assignment Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
@@ -1120,7 +1120,7 @@ int t4_prep_fw(struct adapter *adap, struct fw_info *fw_info,
 		}
 
 		/* Installed successfully, update the cached header too. */
-		memcpy(card_fw, fs_fw, sizeof(*card_fw));
+		*card_fw = *fs_fw;
 		card_fw_usable = 1;
 		*reset = 0;	/* already reset as part of load_fw */
 	}

Original file line number	Diff line number	Diff line change
`@@ -1120,7 +1120,7 @@ int t4_prep_fw(struct adapter adap, struct fw_info fw_info,`
`1120`	`1120`	`}`
`1121`	`1121`
`1122`	`1122`	`/* Installed successfully, update the cached header too. */`
`1123`		`- memcpy(card_fw, fs_fw, sizeof(*card_fw));`
	`1123`	`+ card_fw = fs_fw;`
`1124`	`1124`	`card_fw_usable = 1;`
`1125`	`1125`	`reset = 0; / already reset as part of load_fw */`
`1126`	`1126`	`}`