Skip to content

Commit e461460

Browse files
3x380Vgregkh
authored andcommitted
cdc-acm: avoid interface_to_usbdev call
Pointer to usb_device is already stored in acm structure. Signed-off-by: Ladislav Michl <ladis@linux-mips.org> Acked-by: Oliver Neukum <oneukum@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 90744af commit e461460

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

drivers/usb/class/cdc-acm.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1076,19 +1076,17 @@ static void acm_write_buffers_free(struct acm *acm)
10761076
{
10771077
int i;
10781078
struct acm_wb *wb;
1079-
struct usb_device *usb_dev = interface_to_usbdev(acm->control);
10801079

10811080
for (wb = &acm->wb[0], i = 0; i < ACM_NW; i++, wb++)
1082-
usb_free_coherent(usb_dev, acm->writesize, wb->buf, wb->dmah);
1081+
usb_free_coherent(acm->dev, acm->writesize, wb->buf, wb->dmah);
10831082
}
10841083

10851084
static void acm_read_buffers_free(struct acm *acm)
10861085
{
1087-
struct usb_device *usb_dev = interface_to_usbdev(acm->control);
10881086
int i;
10891087

10901088
for (i = 0; i < acm->rx_buflimit; i++)
1091-
usb_free_coherent(usb_dev, acm->readsize,
1089+
usb_free_coherent(acm->dev, acm->readsize,
10921090
acm->read_buffers[i].base, acm->read_buffers[i].dma);
10931091
}
10941092

@@ -1524,7 +1522,6 @@ static void stop_data_traffic(struct acm *acm)
15241522
static void acm_disconnect(struct usb_interface *intf)
15251523
{
15261524
struct acm *acm = usb_get_intfdata(intf);
1527-
struct usb_device *usb_dev = interface_to_usbdev(intf);
15281525
struct tty_struct *tty;
15291526
int i;
15301527

@@ -1562,7 +1559,7 @@ static void acm_disconnect(struct usb_interface *intf)
15621559
for (i = 0; i < acm->rx_buflimit; i++)
15631560
usb_free_urb(acm->read_urbs[i]);
15641561
acm_write_buffers_free(acm);
1565-
usb_free_coherent(usb_dev, acm->ctrlsize, acm->ctrl_buffer, acm->ctrl_dma);
1562+
usb_free_coherent(acm->dev, acm->ctrlsize, acm->ctrl_buffer, acm->ctrl_dma);
15661563
acm_read_buffers_free(acm);
15671564

15681565
if (!acm->combined_interfaces)

0 commit comments

Comments
 (0)