Skip to content

Commit e478385

Browse files
Andre-ARMrobherring
authored andcommitted
dt-bindings: iommu: arm,smmu-v3: make PRI IRQ optional
The Page Request Interface (PRI) is an optional PCIe feature. As such, a SMMU would not need to handle it if the PCIe host bridge or the SMMU itself do not implement it. Also an SMMU could be connected to a platform device, without any PRI functionality whatsoever. In all cases there would be no SMMU PRI queue interrupt to be wired up to an interrupt controller. At the moment, with the "eventq,gerror,priq,cmdq-sync" order, we would need to sacrifice the command queue sync interrupt as well, which might not be desired. Relax the binding to allow specifying certain useful combinations of wired interrupts, for instance just the "gerror" interrupt, or omitting both "pri" and "cmdq-sync". Signed-off-by: Andre Przywara <andre.przywara@arm.com> Signed-off-by: Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20220506140533.3566431-2-andre.przywara@arm.com
1 parent 1c591c8 commit e478385

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,18 @@ properties:
3737
hardware supports just a single, combined interrupt line.
3838
If provided, then the combined interrupt will be used in preference to
3939
any others.
40-
- minItems: 2
40+
- minItems: 1
4141
items:
42-
- const: eventq # Event Queue not empty
43-
- const: gerror # Global Error activated
44-
- const: priq # PRI Queue not empty
45-
- const: cmdq-sync # CMD_SYNC complete
42+
- enum:
43+
- eventq # Event Queue not empty
44+
- gerror # Global Error activated
45+
- const: gerror
46+
- enum:
47+
- cmdq-sync # CMD_SYNC complete
48+
- priq # PRI Queue not empty
49+
- enum:
50+
- cmdq-sync
51+
- priq
4652

4753
'#iommu-cells':
4854
const: 1

0 commit comments

Comments
 (0)