net: ethernet: aquantia: remove redundant err check

Colin Ian King · davem330 · commit e52cfb63a0ba · 2017-01-29T18:24:00.000-05:00
The check on err &lt; 0 is redundant and can be removed. Detected
by CoverityScan, CID#1398321 ("Logically Dead Code")

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
@@ -145,8 +145,6 @@ int aq_pci_func_init(struct aq_pci_func_s *self)
 		}
 	}
 
-	if (err < 0)
-		goto err_exit;
 	for (i = 0; i < self->aq_hw_caps.msix_irqs; i++)
 		self->msix_entry[i].entry = i;
 

Original file line number	Diff line number	Diff line change
`@@ -145,8 +145,6 @@ int aq_pci_func_init(struct aq_pci_func_s *self)`
`145`	`145`	`}`
`146`	`146`	`}`
`147`	`147`
`148`		`- if (err < 0)`
`149`		`- goto err_exit;`
`150`	`148`	`for (i = 0; i < self->aq_hw_caps.msix_irqs; i++)`
`151`	`149`	`self->msix_entry[i].entry = i;`
`152`	`150`