netfilter: nf_tables: Release memory obtained by kasprintf

ArvindYadavCs · ummakynes · commit e63aaaa6be54 · 2017-10-03T15:21:19.000+02:00
Free memory region, if nf_tables_set_alloc_name is not successful. Fixes: 3874549 ("netfilter: nf_tables: Allow set names of up to 255 chars") Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
@@ -2741,8 +2741,10 @@ static int nf_tables_set_alloc_name(struct nft_ctx *ctx, struct nft_set *set,
 	list_for_each_entry(i, &ctx->table->sets, list) {
 		if (!nft_is_active_next(ctx->net, i))
 			continue;
-		if (!strcmp(set->name, i->name))
+		if (!strcmp(set->name, i->name)) {
+			kfree(set->name);
 			return -ENFILE;
+		}
 	}
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -2741,8 +2741,10 @@ static int nf_tables_set_alloc_name(struct nft_ctx ctx, struct nft_set set,`
`2741`	`2741`	`list_for_each_entry(i, &ctx->table->sets, list) {`
`2742`	`2742`	`if (!nft_is_active_next(ctx->net, i))`
`2743`	`2743`	`continue;`
`2744`		`- if (!strcmp(set->name, i->name))`
	`2744`	`+ if (!strcmp(set->name, i->name)) {`
	`2745`	`+ kfree(set->name);`
`2745`	`2746`	`return -ENFILE;`
	`2747`	`+ }`
`2746`	`2748`	`}`
`2747`	`2749`	`return 0;`
`2748`	`2750`	`}`