Skip to content

Commit e65953d

Browse files
Chunyan Zhangstorulf
authored andcommitted
mmc: sdhci: Add 32-bit block count support for v4 mode
Host Controller Version 4.10 re-defines SDMA System Address register as 32-bit Block Count for v4 mode, and SDMA uses ADMA System Address register (05Fh-058h) instead if v4 mode is enabled. Also when using 32-bit block count, 16-bit block count register need to be set to zero. Since using 32-bit Block Count would cause problems for auto-cmd23, it can be chosen via host->quirk2. Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org> Acked-by: Adrian Hunter <adrian.hunter@intel.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 685e444 commit e65953d

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

drivers/mmc/host/sdhci.c

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1082,7 +1082,19 @@ static void sdhci_prepare_data(struct sdhci_host *host, struct mmc_command *cmd)
10821082
/* Set the DMA boundary value and block size */
10831083
sdhci_writew(host, SDHCI_MAKE_BLKSZ(host->sdma_boundary, data->blksz),
10841084
SDHCI_BLOCK_SIZE);
1085-
sdhci_writew(host, data->blocks, SDHCI_BLOCK_COUNT);
1085+
1086+
/*
1087+
* For Version 4.10 onwards, if v4 mode is enabled, 32-bit Block Count
1088+
* can be supported, in that case 16-bit block count register must be 0.
1089+
*/
1090+
if (host->version >= SDHCI_SPEC_410 && host->v4_mode &&
1091+
(host->quirks2 & SDHCI_QUIRK2_USE_32BIT_BLK_CNT)) {
1092+
if (sdhci_readw(host, SDHCI_BLOCK_COUNT))
1093+
sdhci_writew(host, 0, SDHCI_BLOCK_COUNT);
1094+
sdhci_writew(host, data->blocks, SDHCI_32BIT_BLK_CNT);
1095+
} else {
1096+
sdhci_writew(host, data->blocks, SDHCI_BLOCK_COUNT);
1097+
}
10861098
}
10871099

10881100
static inline bool sdhci_auto_cmd12(struct sdhci_host *host,

drivers/mmc/host/sdhci.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828

2929
#define SDHCI_DMA_ADDRESS 0x00
3030
#define SDHCI_ARGUMENT2 SDHCI_DMA_ADDRESS
31+
#define SDHCI_32BIT_BLK_CNT SDHCI_DMA_ADDRESS
3132

3233
#define SDHCI_BLOCK_SIZE 0x04
3334
#define SDHCI_MAKE_BLKSZ(dma, blksz) (((dma & 0x7) << 12) | (blksz & 0xFFF))
@@ -462,6 +463,13 @@ struct sdhci_host {
462463
* obtainable timeout.
463464
*/
464465
#define SDHCI_QUIRK2_DISABLE_HW_TIMEOUT (1<<17)
466+
/*
467+
* 32-bit block count may not support eMMC where upper bits of CMD23 are used
468+
* for other purposes. Consequently we support 16-bit block count by default.
469+
* Otherwise, SDHCI_QUIRK2_USE_32BIT_BLK_CNT can be selected to use 32-bit
470+
* block count.
471+
*/
472+
#define SDHCI_QUIRK2_USE_32BIT_BLK_CNT (1<<18)
465473

466474
int irq; /* Device IRQ */
467475
void __iomem *ioaddr; /* Mapped address */

0 commit comments

Comments
 (0)