Skip to content

Commit e6eb2eb

Browse files
Laurent Dufourmpe
authored andcommitted
powerpc/xmon: Fix another endiannes issue in RTAS call from xmon
The commit 3b8a3c0 ("powerpc/pseries: Fix endiannes issue in RTAS call from xmon") was fixing an endianness issue in the call made from xmon to RTAS. However, as Michael Ellerman noticed, this fix was not complete, the token value was not byte swapped. This lead to call an unexpected and most of the time unexisting RTAS function, which is silently ignored by RTAS. This fix addresses this hole. Reported-by: Michael Ellerman <mpe@ellerman.id.au> Cc: stable@vger.kernel.org Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
1 parent ec6f34e commit e6eb2eb

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

arch/powerpc/xmon/xmon.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,7 @@ static inline void disable_surveillance(void)
337337
args.token = rtas_token("set-indicator");
338338
if (args.token == RTAS_UNKNOWN_SERVICE)
339339
return;
340+
args.token = cpu_to_be32(args.token);
340341
args.nargs = cpu_to_be32(3);
341342
args.nret = cpu_to_be32(1);
342343
args.rets = &args.args[3];

0 commit comments

Comments
 (0)