Skip to content

Commit e7dc6af

Browse files
masneyblinusw
authored andcommitted
spmi: pmic-arb: revert "disassociate old virq if hwirq mapping already exists"
Now that spmi-gpio is a proper hierarchical IRQ chip, and all in-tree users of device tree have been updated, we can now drop the hack that was introduced to disassociate the old Linux virq if a hwirq mapping already exists. That patch was introduced to not break git bisect for any existing boards. Driver was tested using gpio-keys and iadc/vadc on the LG Nexus 5 (hammerhead) phone. Signed-off-by: Brian Masney <masneyb@onstation.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 135ef21 commit e7dc6af

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/spmi/spmi-pmic-arb.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -745,15 +745,10 @@ static int qpnpint_irq_domain_map(struct spmi_pmic_arb *pmic_arb,
745745
irq_hw_number_t hwirq, unsigned int type)
746746
{
747747
irq_flow_handler_t handler;
748-
unsigned int old_virq;
749748

750749
dev_dbg(&pmic_arb->spmic->dev, "virq = %u, hwirq = %lu, type = %u\n",
751750
virq, hwirq, type);
752751

753-
old_virq = irq_find_mapping(domain, hwirq);
754-
if (old_virq)
755-
irq_domain_disassociate(domain, old_virq);
756-
757752
if (type & IRQ_TYPE_EDGE_BOTH)
758753
handler = handle_edge_irq;
759754
else if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))

0 commit comments

Comments
 (0)