clk: tegra: dfll: Fix debugfs_simple_attr.cocci warnings

YueHaibing · bebarino · commit e7e6198c6056 · 2019-02-22T10:01:21.000-08:00
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.

Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Signed-off-by: YueHaibing &lt;yuehaibing@huawei.com&gt;
Signed-off-by: Stephen Boyd &lt;sboyd@kernel.org&gt;
diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
@@ -1112,8 +1112,8 @@ static int attr_enable_set(void *data, u64 val)
 
 	return val ? dfll_enable(td) : dfll_disable(td);
 }
-DEFINE_SIMPLE_ATTRIBUTE(enable_fops, attr_enable_get, attr_enable_set,
-			"%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(enable_fops, attr_enable_get, attr_enable_set,
+			 "%llu\n");
 
 static int attr_lock_get(void *data, u64 *val)
 {
@@ -1129,8 +1129,7 @@ static int attr_lock_set(void *data, u64 val)
 
 	return val ? dfll_lock(td) :  dfll_unlock(td);
 }
-DEFINE_SIMPLE_ATTRIBUTE(lock_fops, attr_lock_get, attr_lock_set,
-			"%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(lock_fops, attr_lock_get, attr_lock_set, "%llu\n");
 
 static int attr_rate_get(void *data, u64 *val)
 {
@@ -1147,7 +1146,7 @@ static int attr_rate_set(void *data, u64 val)
 
 	return dfll_request_rate(td, val);
 }
-DEFINE_SIMPLE_ATTRIBUTE(rate_fops, attr_rate_get, attr_rate_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(rate_fops, attr_rate_get, attr_rate_set, "%llu\n");
 
 static int attr_registers_show(struct seq_file *s, void *data)
 {
@@ -1196,10 +1195,11 @@ static void dfll_debug_init(struct tegra_dfll *td)
 	root = debugfs_create_dir("tegra_dfll_fcpu", NULL);
 	td->debugfs_dir = root;
 
-	debugfs_create_file("enable", S_IRUGO | S_IWUSR, root, td, &enable_fops);
-	debugfs_create_file("lock", S_IRUGO, root, td, &lock_fops);
-	debugfs_create_file("rate", S_IRUGO, root, td, &rate_fops);
-	debugfs_create_file("registers", S_IRUGO, root, td, &attr_registers_fops);
+	debugfs_create_file_unsafe("enable", 0644, root, td,
+				   &enable_fops);
+	debugfs_create_file_unsafe("lock", 0444, root, td, &lock_fops);
+	debugfs_create_file_unsafe("rate", 0444, root, td, &rate_fops);
+	debugfs_create_file("registers", 0444, root, td, &attr_registers_fops);
 }
 
 #else

Original file line number	Diff line number	Diff line change
`@@ -1112,8 +1112,8 @@ static int attr_enable_set(void *data, u64 val)`
`1112`	`1112`
`1113`	`1113`	`return val ? dfll_enable(td) : dfll_disable(td);`
`1114`	`1114`	`}`
`1115`		`-DEFINE_SIMPLE_ATTRIBUTE(enable_fops, attr_enable_get, attr_enable_set,`
`1116`		`- "%llu\n");`
	`1115`	`+DEFINE_DEBUGFS_ATTRIBUTE(enable_fops, attr_enable_get, attr_enable_set,`
	`1116`	`+ "%llu\n");`
`1117`	`1117`
`1118`	`1118`	`static int attr_lock_get(void data, u64 val)`
`1119`	`1119`	`{`
`@@ -1129,8 +1129,7 @@ static int attr_lock_set(void *data, u64 val)`
`1129`	`1129`
`1130`	`1130`	`return val ? dfll_lock(td) : dfll_unlock(td);`
`1131`	`1131`	`}`
`1132`		`-DEFINE_SIMPLE_ATTRIBUTE(lock_fops, attr_lock_get, attr_lock_set,`
`1133`		`- "%llu\n");`
	`1132`	`+DEFINE_DEBUGFS_ATTRIBUTE(lock_fops, attr_lock_get, attr_lock_set, "%llu\n");`
`1134`	`1133`
`1135`	`1134`	`static int attr_rate_get(void data, u64 val)`
`1136`	`1135`	`{`
`@@ -1147,7 +1146,7 @@ static int attr_rate_set(void *data, u64 val)`
`1147`	`1146`
`1148`	`1147`	`return dfll_request_rate(td, val);`
`1149`	`1148`	`}`
`1150`		`-DEFINE_SIMPLE_ATTRIBUTE(rate_fops, attr_rate_get, attr_rate_set, "%llu\n");`
	`1149`	`+DEFINE_DEBUGFS_ATTRIBUTE(rate_fops, attr_rate_get, attr_rate_set, "%llu\n");`
`1151`	`1150`
`1152`	`1151`	`static int attr_registers_show(struct seq_file s, void data)`
`1153`	`1152`	`{`
`@@ -1196,10 +1195,11 @@ static void dfll_debug_init(struct tegra_dfll *td)`
`1196`	`1195`	`root = debugfs_create_dir("tegra_dfll_fcpu", NULL);`
`1197`	`1196`	`td->debugfs_dir = root;`
`1198`	`1197`
`1199`		`- debugfs_create_file("enable", S_IRUGO \| S_IWUSR, root, td, &enable_fops);`
`1200`		`- debugfs_create_file("lock", S_IRUGO, root, td, &lock_fops);`
`1201`		`- debugfs_create_file("rate", S_IRUGO, root, td, &rate_fops);`
`1202`		`- debugfs_create_file("registers", S_IRUGO, root, td, &attr_registers_fops);`
	`1198`	`+ debugfs_create_file_unsafe("enable", 0644, root, td,`
	`1199`	`+ &enable_fops);`
	`1200`	`+ debugfs_create_file_unsafe("lock", 0444, root, td, &lock_fops);`
	`1201`	`+ debugfs_create_file_unsafe("rate", 0444, root, td, &rate_fops);`
	`1202`	`+ debugfs_create_file("registers", 0444, root, td, &attr_registers_fops);`
`1203`	`1203`	`}`
`1204`	`1204`
`1205`	`1205`	`#else`