scsi: target/tcmu: Fix queue_cmd_ring() declaration

bvanassche · martinkpetersen · commit e7f411049f51 · 2018-12-07T21:20:07.000-05:00
This patch does not change any functionality but avoids that sparse complains about the queue_cmd_ring() function and its callers. Fixes: 6fd0ce7 ("tcmu: prep queue_cmd_ring to be used by unmap wq") Reviewed-by: David Disseldorp <ddiss@suse.de> Cc: Nicholas Bellinger <nab@linux-iscsi.org> Cc: Mike Christie <mchristi@redhat.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Hannes Reinecke <hare@suse.de> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
@@ -958,7 +958,7 @@ static int add_to_cmdr_queue(struct tcmu_cmd *tcmu_cmd)
  *  0 success
  *  1 internally queued to wait for ring memory to free.
  */
-static sense_reason_t queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, int *scsi_err)
+static int queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, sense_reason_t *scsi_err)
 {
 	struct tcmu_dev *udev = tcmu_cmd->tcmu_dev;
 	struct se_cmd *se_cmd = tcmu_cmd->se_cmd;

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,7 @@ static int add_to_cmdr_queue(struct tcmu_cmd *tcmu_cmd)`
`958`	`958`	`* 0 success`
`959`	`959`	`* 1 internally queued to wait for ring memory to free.`
`960`	`960`	`*/`
`961`		`-static sense_reason_t queue_cmd_ring(struct tcmu_cmd tcmu_cmd, int scsi_err)`
	`961`	`+static int queue_cmd_ring(struct tcmu_cmd tcmu_cmd, sense_reason_t scsi_err)`
`962`	`962`	`{`
`963`	`963`	`struct tcmu_dev *udev = tcmu_cmd->tcmu_dev;`
`964`	`964`	`struct se_cmd *se_cmd = tcmu_cmd->se_cmd;`