Skip to content

Commit e84025e

Browse files
daviddaneyrafaeljw
authored andcommitted
ACPI / NUMA: move bad_srat() and srat_disabled() to drivers/acpi/numa.c
bad_srat() and srat_disabled() are shared by x86 and follow-on arm64 patches. Move them to drivers/acpi/numa.c in preparation for arm64 support. Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> Signed-off-by: Robert Richter <rrichter@cavium.com> [david.daney@cavium.com moved definitions to drivers/acpi/numa.c] Signed-off-by: David Daney <david.daney@cavium.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 2faeff1 commit e84025e

File tree

5 files changed

+17
-15
lines changed

5 files changed

+17
-15
lines changed

arch/x86/include/asm/acpi.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ static inline void disable_acpi(void) { }
145145
#define ARCH_HAS_POWER_INIT 1
146146

147147
#ifdef CONFIG_ACPI_NUMA
148-
extern int acpi_numa;
149148
extern int x86_acpi_numa_init(void);
150149
#endif /* CONFIG_ACPI_NUMA */
151150

arch/x86/mm/numa.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
/* Common code for 32 and 64-bit NUMA */
2+
#include <linux/acpi.h>
23
#include <linux/kernel.h>
34
#include <linux/mm.h>
45
#include <linux/string.h>
@@ -15,7 +16,6 @@
1516
#include <asm/e820.h>
1617
#include <asm/proto.h>
1718
#include <asm/dma.h>
18-
#include <asm/acpi.h>
1919
#include <asm/amd_nb.h>
2020

2121
#include "numa_internal.h"

arch/x86/mm/srat.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,19 +24,6 @@
2424
#include <asm/apic.h>
2525
#include <asm/uv/uv.h>
2626

27-
int acpi_numa __initdata;
28-
29-
static __init void bad_srat(void)
30-
{
31-
printk(KERN_ERR "SRAT: SRAT not used.\n");
32-
acpi_numa = -1;
33-
}
34-
35-
static __init inline int srat_disabled(void)
36-
{
37-
return acpi_numa < 0;
38-
}
39-
4027
/* Callback for Proximity Domain -> x2APIC mapping */
4128
void __init
4229
acpi_numa_x2apic_affinity_init(struct acpi_srat_x2apic_cpu_affinity *pa)

drivers/acpi/numa.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ static int node_to_pxm_map[MAX_NUMNODES]
4040
= { [0 ... MAX_NUMNODES - 1] = PXM_INVAL };
4141

4242
unsigned char acpi_srat_revision __initdata;
43+
int acpi_numa __initdata;
4344

4445
int pxm_to_node(int pxm)
4546
{
@@ -197,6 +198,17 @@ static int __init slit_valid(struct acpi_table_slit *slit)
197198
return 1;
198199
}
199200

201+
void __init bad_srat(void)
202+
{
203+
pr_err("SRAT: SRAT not used.\n");
204+
acpi_numa = -1;
205+
}
206+
207+
int __init srat_disabled(void)
208+
{
209+
return acpi_numa < 0;
210+
}
211+
200212
#if defined(CONFIG_X86) || defined(CONFIG_ARM64)
201213
/*
202214
* Callback for SLIT parsing. pxm_to_node() returns NUMA_NO_NODE for

include/acpi/acpi_numa.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ extern int pxm_to_node(int);
1515
extern int node_to_pxm(int);
1616
extern int acpi_map_pxm_to_node(int);
1717
extern unsigned char acpi_srat_revision;
18+
extern int acpi_numa __initdata;
19+
20+
extern void bad_srat(void);
21+
extern int srat_disabled(void);
1822

1923
#endif /* CONFIG_ACPI_NUMA */
2024
#endif /* __ACP_NUMA_H */

0 commit comments

Comments
 (0)