Skip to content

Commit e878c5e

Browse files
Jens Remusdavem330
authored andcommitted
s390/qeth: tidy up parameter naming for qeth_do_send_packet()
Cppcheck reports the following for drivers/s390/net/qeth_core.h: warning - line 1560 - Function 'qeth_do_send_packet' argument order different: declaration 'card, queue, skb, hdr, hd_len, offset, elements' definition 'card, queue, skb, hdr, offset, hd_len, elements_needed'. Match the naming in the function's declaration against its definition. Signed-off-by: Jens Remus <jremus@linux.vnet.ibm.com> Reviewed-by: Julian Wiedmann <jwi@linux.vnet.ibm.com> Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent d7aa9d0 commit e878c5e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/s390/net/qeth_core.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -967,7 +967,8 @@ int qeth_do_send_packet_fast(struct qeth_qdio_out_q *queue, struct sk_buff *skb,
967967
unsigned int hd_len);
968968
int qeth_do_send_packet(struct qeth_card *card, struct qeth_qdio_out_q *queue,
969969
struct sk_buff *skb, struct qeth_hdr *hdr,
970-
unsigned int hd_len, unsigned int offset, int elements);
970+
unsigned int offset, unsigned int hd_len,
971+
int elements_needed);
971972
int qeth_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);
972973
int qeth_core_get_sset_count(struct net_device *, int);
973974
void qeth_core_get_ethtool_stats(struct net_device *,

0 commit comments

Comments
 (0)