ata: ahci_xgene: Fix compilation warning

Damien Le Moal · Damien Le Moal · commit e8fbdf1855f7 · 2022-10-18T08:02:14.000+09:00
When compiling with clang and W=1, the following warning is generated:

drivers/ata/ahci_xgene.c:788:14: error: cast to smaller integer type
'enum xgene_ahci_version' from 'const void *'
[-Werror,-Wvoid-pointer-to-enum-cast]
       version = (enum xgene_ahci_version) of_devid-&gt;data;
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fix this by using a cast to unsigned long to match the "void *" type
size of of_devid-&gt;data.

Signed-off-by: Damien Le Moal &lt;damien.lemoal@opensource.wdc.com&gt;
Acked-by: Arnd Bergmann &lt;arnd@arndb.de&gt;
diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
@@ -785,7 +785,7 @@ static int xgene_ahci_probe(struct platform_device *pdev)
 	of_devid = of_match_device(xgene_ahci_of_match, dev);
 	if (of_devid) {
 		if (of_devid->data)
-			version = (enum xgene_ahci_version) of_devid->data;
+			version = (unsigned long) of_devid->data;
 	}
 #ifdef CONFIG_ACPI
 	else {

Original file line number	Diff line number	Diff line change
`@@ -785,7 +785,7 @@ static int xgene_ahci_probe(struct platform_device *pdev)`
`785`	`785`	`of_devid = of_match_device(xgene_ahci_of_match, dev);`
`786`	`786`	`if (of_devid) {`
`787`	`787`	`if (of_devid->data)`
`788`		`- version = (enum xgene_ahci_version) of_devid->data;`
	`788`	`+ version = (unsigned long) of_devid->data;`
`789`	`789`	`}`
`790`	`790`	`#ifdef CONFIG_ACPI`
`791`	`791`	`else {`