ACPI / EC: Fix an issue that SCI_EVT cannot be detected after event is enabled

Lv Zheng · rafaeljw · commit e923e8e79e18 · 2016-08-31T00:32:10.000+02:00
After enabling the EC event handling, Linux is still in the noirq stage, if
there is no triggering source (EC transaction, GPE STS status),
advance_transaction() will not be invoked and SCI_EVT cannot be detected.
This patch adds one more triggering source after enabling the EC event
handling to poll the pending SCI_EVT.

Known issues:
1. Still no SCI_EVT triggering source
   There could still be no SCI_EVT triggering source after handling the
   first SCI_EVT (polled by this patch if any). Because after handling the
   first SCI_EVT, Linux could still be in noirq stage and there could still
   be no further triggering source in this stage. Then the second SCI_EVT
   indicated during this stage still cannot be detected by the EC driver.
   With this improvement applied, it is then possible to move
   acpi_ec_enable_event() out of the noirq stage to fix this issue (if the
   first SCI_EVT is handled out of the noirq stage, the follow-up SCI_EVTs
   should be able to trigger IRQs).

Signed-off-by: Lv Zheng &lt;lv.zheng@intel.com&gt;
Tested-by: Todd E Brandt &lt;todd.e.brandt@linux.intel.com&gt;
Signed-off-by: Rafael J. Wysocki &lt;rafael.j.wysocki@intel.com&gt;
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
@@ -468,6 +468,8 @@ static inline void __acpi_ec_enable_event(struct acpi_ec *ec)
 {
 	if (!test_and_set_bit(EC_FLAGS_QUERY_ENABLED, &ec->flags))
 		ec_log_drv("event unblocked");
+	if (!test_bit(EC_FLAGS_QUERY_PENDING, &ec->flags))
+		advance_transaction(ec);
 }
 
 static inline void __acpi_ec_disable_event(struct acpi_ec *ec)

Original file line number	Diff line number	Diff line change
`@@ -468,6 +468,8 @@ static inline void __acpi_ec_enable_event(struct acpi_ec *ec)`
`468`	`468`	`{`
`469`	`469`	`if (!test_and_set_bit(EC_FLAGS_QUERY_ENABLED, &ec->flags))`
`470`	`470`	`ec_log_drv("event unblocked");`
	`471`	`+ if (!test_bit(EC_FLAGS_QUERY_PENDING, &ec->flags))`
	`472`	`+ advance_transaction(ec);`
`471`	`473`	`}`
`472`	`474`
`473`	`475`	`static inline void __acpi_ec_disable_event(struct acpi_ec *ec)`