block: Add default switch case to blk_pm_allow_request() to kill warning

geertu · axboe · commit e9a83853302b · 2018-07-09T09:07:54.000-06:00
With gcc 4.9.0 and 7.3.0: block/blk-core.c: In function 'blk_pm_allow_request': block/blk-core.c:2747:2: warning: enumeration value 'RPM_ACTIVE' not handled in switch [-Wswitch] switch (rq->q->rpm_status) { ^ Convert the return statement below the switch() block into a default case to fix this. Fixes: e4f36b2 ("block: fix peeking requests during PM") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
diff --git a/block/blk-core.c b/block/blk-core.c
@@ -2753,9 +2753,9 @@ static bool blk_pm_allow_request(struct request *rq)
 		return rq->rq_flags & RQF_PM;
 	case RPM_SUSPENDED:
 		return false;
+	default:
+		return true;
 	}
-
-	return true;
 }
 #else
 static bool blk_pm_allow_request(struct request *rq)

Original file line number	Diff line number	Diff line change
`@@ -2753,9 +2753,9 @@ static bool blk_pm_allow_request(struct request *rq)`
`2753`	`2753`	`return rq->rq_flags & RQF_PM;`
`2754`	`2754`	`case RPM_SUSPENDED:`
`2755`	`2755`	`return false;`
	`2756`	`+ default:`
	`2757`	`+ return true;`
`2756`	`2758`	`}`
`2757`		`-`
`2758`		`- return true;`
`2759`	`2759`	`}`
`2760`	`2760`	`#else`
`2761`	`2761`	`static bool blk_pm_allow_request(struct request *rq)`