xfs: Fix leak of discard bio

jankara · djwong · commit ea7bd56fa309 · 2017-08-04T13:43:36.000-07:00
The bio describing discard operation is allocated by __blkdev_issue_discard() which returns us a reference to it. That reference is never released and thus we leak this bio. Drop the bio reference once it completes in xlog_discard_endio(). CC: stable@vger.kernel.org Fixes: 4560e78 Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c
@@ -539,6 +539,7 @@ xlog_discard_endio(
 
 	INIT_WORK(&ctx->discard_endio_work, xlog_discard_endio_work);
 	queue_work(xfs_discard_wq, &ctx->discard_endio_work);
+	bio_put(bio);
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -539,6 +539,7 @@ xlog_discard_endio(`
`539`	`539`
`540`	`540`	`INIT_WORK(&ctx->discard_endio_work, xlog_discard_endio_work);`
`541`	`541`	`queue_work(xfs_discard_wq, &ctx->discard_endio_work);`
	`542`	`+ bio_put(bio);`
`542`	`543`	`}`
`543`	`544`
`544`	`545`	`static void`