Skip to content

Commit eb8895d

Browse files
Phil Oesterdavem330
authored andcommitted
tcp: tcp_make_synack() should use sock_wmalloc
In commit 90ba9b1 (tcp: tcp_make_synack() can use alloc_skb()), Eric changed the call to sock_wmalloc in tcp_make_synack to alloc_skb. In doing so, the netfilter owner match lost its ability to block the SYNACK packet on outbound listening sockets. Revert the change, restoring the owner match functionality. This closes netfilter bugzilla torvalds#847. Signed-off-by: Phil Oester <kernel@linuxace.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent cc0fdd8 commit eb8895d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/ipv4/tcp_output.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2670,7 +2670,7 @@ struct sk_buff *tcp_make_synack(struct sock *sk, struct dst_entry *dst,
26702670
int tcp_header_size;
26712671
int mss;
26722672

2673-
skb = alloc_skb(MAX_TCP_HEADER + 15, sk_gfp_atomic(sk, GFP_ATOMIC));
2673+
skb = sock_wmalloc(sk, MAX_TCP_HEADER + 15, 1, GFP_ATOMIC);
26742674
if (unlikely(!skb)) {
26752675
dst_release(dst);
26762676
return NULL;

0 commit comments

Comments
 (0)