vfio-pci: Add missing break to enable VFIO_PCI_ERR_IRQ_INDEX

aik · awilliam · commit ec76f4007079 · 2015-03-12T09:51:38.000-06:00
This adds a missing break statement to VFIO_DEVICE_SET_IRQS handler without which vfio_pci_set_err_trigger() would never be called. While we are here, add another "break" to VFIO_PCI_REQ_IRQ_INDEX case so if we add more indexes later, we won't miss it. Fixes: 6140a8f ("vfio-pci: Add device request interface") Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -868,12 +868,14 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev, uint32_t flags,
 				func = vfio_pci_set_err_trigger;
 			break;
 		}
+		break;
 	case VFIO_PCI_REQ_IRQ_INDEX:
 		switch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) {
 		case VFIO_IRQ_SET_ACTION_TRIGGER:
 			func = vfio_pci_set_req_trigger;
 			break;
 		}
+		break;
 	}
 
 	if (!func)

Original file line number	Diff line number	Diff line change
`@@ -868,12 +868,14 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev, uint32_t flags,`
`868`	`868`	`func = vfio_pci_set_err_trigger;`
`869`	`869`	`break;`
`870`	`870`	`}`
	`871`	`+ break;`
`871`	`872`	`case VFIO_PCI_REQ_IRQ_INDEX:`
`872`	`873`	`switch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) {`
`873`	`874`	`case VFIO_IRQ_SET_ACTION_TRIGGER:`
`874`	`875`	`func = vfio_pci_set_req_trigger;`
`875`	`876`	`break;`
`876`	`877`	`}`
	`878`	`+ break;`
`877`	`879`	`}`
`878`	`880`
`879`	`881`	`if (!func)`