clocksource: armada-370-xp: Replace WARN_ON with BUG_ON

ezequielgarcia · dlezcano · commit ec8e51120a5b · 2013-09-02T21:44:13.000+02:00
If the clock fails to be obtained and the timer fails to be properly
registered, the kernel will freeze real soon. Instead, let's BUG()
where the actual problem is located.

Signed-off-by: Ezequiel Garcia &lt;ezequiel.garcia@free-electrons.com&gt;
Signed-off-by: Daniel Lezcano &lt;daniel.lezcano@linaro.org&gt;
Acked-by: Jason Cooper &lt;jason@lakedaemon.net&gt;
Acked-by: Gregory CLEMENT &lt;gregory.clement@free-electrons.com&gt;
diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
@@ -306,7 +306,7 @@ static void __init armada_370_timer_init(struct device_node *np)
 {
 	struct clk *clk = of_clk_get(np, 0);
 
-	WARN_ON(IS_ERR(clk));
+	BUG_ON(IS_ERR(clk));
 	timer_clk = clk_get_rate(clk) / TIMER_DIVIDER;
 	timer25Mhz = false;
 

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,7 @@ static void __init armada_370_timer_init(struct device_node *np)`
`306`	`306`	`{`
`307`	`307`	`struct clk *clk = of_clk_get(np, 0);`
`308`	`308`
`309`		`- WARN_ON(IS_ERR(clk));`
	`309`	`+ BUG_ON(IS_ERR(clk));`
`310`	`310`	`timer_clk = clk_get_rate(clk) / TIMER_DIVIDER;`
`311`	`311`	`timer25Mhz = false;`
`312`	`312`