net: Properly unlink GRO packets on overflow.

davem330 · davem330 · commit ece23711dd95 · 2018-10-28T10:35:12.000-07:00
Just like with normal GRO processing, we have to initialize skb->next to NULL when we unlink overflow packets from the GRO hash lists. Fixes: d4546c2 ("net: Convert GRO SKB handling to list_head.") Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name> Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/core/dev.c b/net/core/dev.c
@@ -5457,7 +5457,7 @@ static void gro_flush_oldest(struct list_head *head)
 	/* Do not adjust napi->gro_hash[].count, caller is adding a new
 	 * SKB to the chain.
 	 */
-	list_del(&oldest->list);
+	skb_list_del_init(oldest);
 	napi_gro_complete(oldest);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5457,7 +5457,7 @@ static void gro_flush_oldest(struct list_head *head)`
`5457`	`5457`	`/* Do not adjust napi->gro_hash[].count, caller is adding a new`
`5458`	`5458`	`* SKB to the chain.`
`5459`	`5459`	`*/`
`5460`		`- list_del(&oldest->list);`
	`5460`	`+ skb_list_del_init(oldest);`
`5461`	`5461`	`napi_gro_complete(oldest);`
`5462`	`5462`	`}`
`5463`	`5463`