Skip to content

Commit edb527c

Browse files
Mark HaverkampJames Bottomley
authored andcommitted
[SCSI] aacraid: remove unneeded locking
Received From Mark Salyzyn Since new commands to the card are quiesced, respect the changes in the SCSI error path which dropped locking around the hba reset handler and similarly drop the lock requirement in the driver's path. Signed-off-by: Mark Haverkamp <markh@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
1 parent 2ca48a1 commit edb527c

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/scsi/aacraid/linit.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -453,15 +453,10 @@ static int aac_eh_reset(struct scsi_cmnd* cmd)
453453

454454
printk(KERN_ERR "%s: Host adapter reset request. SCSI hang ?\n",
455455
AAC_DRIVERNAME);
456-
457-
458-
spin_lock_irq(host->host_lock);
459-
460456
aac = (struct aac_dev *)host->hostdata;
461457
if (aac_adapter_check_health(aac)) {
462458
printk(KERN_ERR "%s: Host adapter appears dead\n",
463459
AAC_DRIVERNAME);
464-
spin_unlock_irq(host->host_lock);
465460
return -ENODEV;
466461
}
467462
/*
@@ -487,13 +482,10 @@ static int aac_eh_reset(struct scsi_cmnd* cmd)
487482
/*
488483
* We can exit If all the commands are complete
489484
*/
490-
spin_unlock_irq(host->host_lock);
491485
if (active == 0)
492486
return SUCCESS;
493487
ssleep(1);
494-
spin_lock_irq(host->host_lock);
495488
}
496-
spin_unlock_irq(host->host_lock);
497489
printk(KERN_ERR "%s: SCSI bus appears hung\n", AAC_DRIVERNAME);
498490
return -ETIMEDOUT;
499491
}

0 commit comments

Comments
 (0)