mm/slub.c: freelist is ensured to be NULL when new_slab() fails

Peng Wang · torvalds · commit edde82b6df70 · 2019-03-05T21:07:14.000-08:00
new_slab_objects() will return immediately if freelist is not NULL. if (freelist) return freelist; One more assignment operation could be avoided. Link: http://lkml.kernel.org/r/20181229062512.30469-1-rocking@whu.edu.cn Signed-off-by: Peng Wang <rocking@whu.edu.cn> Reviewed-by: Pekka Enberg <penberg@kernel.org> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: David Rientjes <rientjes@google.com> Cc: Christoph Lameter <cl@linux.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
diff --git a/mm/slub.c b/mm/slub.c
@@ -2482,8 +2482,7 @@ static inline void *new_slab_objects(struct kmem_cache *s, gfp_t flags,
 		stat(s, ALLOC_SLAB);
 		c->page = page;
 		*pc = c;
-	} else
-		freelist = NULL;
+	}
 
 	return freelist;
 }

Original file line number	Diff line number	Diff line change
`@@ -2482,8 +2482,7 @@ static inline void new_slab_objects(struct kmem_cache s, gfp_t flags,`
`2482`	`2482`	`stat(s, ALLOC_SLAB);`
`2483`	`2483`	`c->page = page;`
`2484`	`2484`	`*pc = c;`
`2485`		`- } else`
`2486`		`- freelist = NULL;`
	`2485`	`+ }`
`2487`	`2486`
`2488`	`2487`	`return freelist;`
`2489`	`2488`	`}`