Skip to content

Commit ee5de8d

Browse files
lwfingergregkh
authored andcommitted
staging: r8821ae: Fix build problems
As initially introduced, this driver failed to build in the linux-next tree due to changes coming from newer developments arising in the wireless trees. This patch removes incompatible code and provides definitions for symbols that have been removed from mac80211. In addition, several warnings were fixed. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent cc11f37 commit ee5de8d

File tree

6 files changed

+17
-12
lines changed

6 files changed

+17
-12
lines changed

drivers/staging/rtl8821ae/base.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,6 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
369369

370370
/* TODO: Correct this value for our hw */
371371
/* TODO: define these hard code value */
372-
hw->channel_change_time = 100;
373372
hw->max_listen_interval = 10;
374373
hw->max_rate_tries = 4;
375374
/* hw->max_rates = 1; */
@@ -1182,7 +1181,7 @@ void rtl_beacon_statistic(struct ieee80211_hw *hw, struct sk_buff *skb)
11821181
return;
11831182

11841183
/* and only beacons from the associated BSSID, please */
1185-
if (compare_ether_addr(hdr->addr3, rtlpriv->mac80211.bssid))
1184+
if (ether_addr_equal(hdr->addr3, rtlpriv->mac80211.bssid))
11861185
return;
11871186

11881187
rtlpriv->link_info.bcn_rx_inperiod ++;
@@ -1650,7 +1649,7 @@ void rtl_recognize_peer(struct ieee80211_hw *hw, u8 *data, unsigned int len)
16501649
return;
16511650

16521651
/* and only beacons from the associated BSSID, please */
1653-
if (compare_ether_addr(hdr->addr3, rtlpriv->mac80211.bssid))
1652+
if (ether_addr_equal(hdr->addr3, rtlpriv->mac80211.bssid))
16541653
return;
16551654

16561655
if (rtl_find_221_ie(hw, data, len)) {

drivers/staging/rtl8821ae/ps.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ void rtl_swlps_beacon(struct ieee80211_hw *hw, void *data, unsigned int len)
527527
return;
528528

529529
/* and only beacons from the associated BSSID, please */
530-
if (compare_ether_addr(hdr->addr3, rtlpriv->mac80211.bssid))
530+
if (ether_addr_equal(hdr->addr3, rtlpriv->mac80211.bssid))
531531
return;
532532

533533
rtlpriv->psc.last_beacon = jiffies;
@@ -1007,7 +1007,7 @@ void rtl_p2p_info(struct ieee80211_hw *hw, void *data, unsigned int len)
10071007
return;
10081008

10091009
/* and only beacons from the associated BSSID, please */
1010-
if (compare_ether_addr(hdr->addr3, rtlpriv->mac80211.bssid))
1010+
if (ether_addr_equal(hdr->addr3, rtlpriv->mac80211.bssid))
10111011
return;
10121012

10131013
/* check if this really is a beacon */

drivers/staging/rtl8821ae/regd.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@
3030
#ifndef __RTL_REGD_H__
3131
#define __RTL_REGD_H__
3232

33+
#define IEEE80211_CHAN_NO_IBSS 1<<2
34+
#define IEEE80211_CHAN_PASSIVE_SCAN 1<<1
35+
#define WIPHY_FLAG_CUSTOM_REGULATORY BIT(0)
36+
#define WIPHY_FLAG_STRICT_REGULATORY BIT(1)
37+
#define WIPHY_FLAG_DISABLE_BEACON_HINTS BIT(2)
38+
3339
struct country_code_to_enum_rd {
3440
u16 countrycode;
3541
const char *iso_name;

drivers/staging/rtl8821ae/rtl8821ae/dm.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1339,7 +1339,7 @@ void rtl8812ae_dm_txpwr_track_set_pwr(struct ieee80211_hw *hw,
13391339
u32 final_bb_swing_idx[2];
13401340
u8 pwr_tracking_limit = 26; /*+1.0dB*/
13411341
u8 tx_rate = 0xFF;
1342-
char final_ofdm_swing_index = 0;
1342+
s8 final_ofdm_swing_index = 0;
13431343

13441344
if(rtldm->tx_rate != 0xFF)
13451345
tx_rate = rtl8812ae_hw_rate_to_mrate(hw, rtldm->tx_rate);
@@ -1999,7 +1999,7 @@ void rtl8821ae_dm_txpwr_track_set_pwr(struct ieee80211_hw *hw,
19991999
u32 final_bb_swing_idx[1];
20002000
u8 pwr_tracking_limit = 26; /*+1.0dB*/
20012001
u8 tx_rate = 0xFF;
2002-
char final_ofdm_swing_index = 0;
2002+
s8 final_ofdm_swing_index = 0;
20032003

20042004
if(rtldm->tx_rate != 0xFF)
20052005
tx_rate = rtl8812ae_hw_rate_to_mrate(hw, rtldm->tx_rate);
@@ -2599,8 +2599,8 @@ static void rtl8821ae_dm_check_edca_turbo(struct ieee80211_hw *hw)
25992599
struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
26002600

26012601
/*Keep past Tx/Rx packet count for RT-to-RT EDCA turbo.*/
2602-
u64 cur_tx_ok_cnt = 0;
2603-
u64 cur_rx_ok_cnt = 0;
2602+
unsigned long cur_tx_ok_cnt = 0;
2603+
unsigned long cur_rx_ok_cnt = 0;
26042604
u32 edca_be_ul = 0x5ea42b;
26052605
u32 edca_be_dl = 0x5ea42b;
26062606
u32 edca_be = 0x5ea42b;

drivers/staging/rtl8821ae/rtl8821ae/phy.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3427,7 +3427,7 @@ void _rtl8812ae_iqk_tx(
34273427
bool iqk0_ready = false, tx0_finish = false, rx0_finish = false;
34283428
bool tx1iqkok = false, rx1iqkok = false, tx1_fail = true, rx1_fail;
34293429
bool iqk1_ready = false, tx1_finish = false, rx1_finish = false, vdf_enable = false;
3430-
int i, tx_dt[3], rx_dt[3], ii, dx = 0, dy = 0;
3430+
int i, tx_dt[3] = {0}, rx_dt[3] = {0}, ii, dx = 0, dy = 0;
34313431

34323432
RT_TRACE(COMP_IQK, DBG_LOUD,
34333433
("BandWidth = %d.\n",

drivers/staging/rtl8821ae/rtl8821ae/trx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -458,13 +458,13 @@ static void _rtl8821ae_translate_rx_signal_stuff(struct ieee80211_hw *hw,
458458
memcpy(pstatus->psaddr, psaddr, ETH_ALEN);
459459

460460
b_packet_matchbssid = ((IEEE80211_FTYPE_CTL != type) &&
461-
(!compare_ether_addr(mac->bssid, (fc & IEEE80211_FCTL_TODS) ?
461+
(!ether_addr_equal(mac->bssid, (fc & IEEE80211_FCTL_TODS) ?
462462
hdr->addr1 : (fc & IEEE80211_FCTL_FROMDS) ?
463463
hdr->addr2 : hdr->addr3)) && (!pstatus->b_hwerror) &&
464464
(!pstatus->b_crc) && (!pstatus->b_icv));
465465

466466
b_packet_toself = b_packet_matchbssid &&
467-
(!compare_ether_addr(praddr, rtlefuse->dev_addr));
467+
(!ether_addr_equal(praddr, rtlefuse->dev_addr));
468468

469469
if (ieee80211_is_beacon(fc))
470470
b_packet_beacon = true;

0 commit comments

Comments
 (0)