Skip to content

Commit eecbad7

Browse files
Andreea-Cristina Bernatjoergroedel
authored andcommitted
iommu: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment: "1. This use of RCU_INIT_POINTER() is NULLing out the pointer" it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ - rcu_assign_pointer + RCU_INIT_POINTER (..., NULL) Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent f63ef69 commit eecbad7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/iommu/dmar.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ int dmar_remove_dev_scope(struct dmar_pci_notify_info *info, u16 segment,
247247

248248
for_each_active_dev_scope(devices, count, index, tmp)
249249
if (tmp == &info->dev->dev) {
250-
rcu_assign_pointer(devices[index].dev, NULL);
250+
RCU_INIT_POINTER(devices[index].dev, NULL);
251251
synchronize_rcu();
252252
put_device(tmp);
253253
return 1;

0 commit comments

Comments
 (0)