ASoC: omap-mcbsp: No need to initialize max_xx_thres when it is not used

Peter Ujfalusi · broonie · commit f15c19af929d · 2018-11-13T09:50:32.000-08:00
Initializing to -EINVAL is not correct as the variables are unsigned and
if buffer_size is 0 then they are not used anyway.

Signed-off-by: Peter Ujfalusi &lt;peter.ujfalusi@ti.com&gt;
Acked-by: Jarkko Nikula &lt;jarkko.nikula@bitmer.com&gt;
Tested-by: Jarkko Nikula &lt;jarkko.nikula@bitmer.com&gt;
Signed-off-by: Mark Brown &lt;broonie@kernel.org&gt;
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
@@ -727,9 +727,6 @@ static int omap_mcbsp_init(struct platform_device *pdev)
 				"Unable to create additional controls\n");
 			goto err_thres;
 		}
-	} else {
-		mcbsp->max_tx_thres = -EINVAL;
-		mcbsp->max_rx_thres = -EINVAL;
 	}
 
 	ret = omap_mcbsp_st_init(pdev);

Original file line number	Diff line number	Diff line change
`@@ -727,9 +727,6 @@ static int omap_mcbsp_init(struct platform_device *pdev)`
`727`	`727`	`"Unable to create additional controls\n");`
`728`	`728`	`goto err_thres;`
`729`	`729`	`}`
`730`		`- } else {`
`731`		`- mcbsp->max_tx_thres = -EINVAL;`
`732`		`- mcbsp->max_rx_thres = -EINVAL;`
`733`	`730`	`}`
`734`	`731`
`735`	`732`	`ret = omap_mcbsp_st_init(pdev);`