dm raid: fix processing of max_recovery_rate constructor flag

mauelsha · snitm · commit f15f64d65bc0 · 2016-08-03T10:30:52.000-04:00
__CTR_FLAG_MIN_RECOVERY_RATE was used instead of __CTR_FLAG_MAX_RECOVERY_RATE
thus causing max_recovery_rate to be rejected in case min_recovery_rate
was already set.

Signed-off-by: Heinz Mauelshagen &lt;heinzm@redhat.com&gt;
Signed-off-by: Mike Snitzer &lt;snitzer@redhat.com&gt;
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
@@ -1270,7 +1270,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
 			}
 			rs->md.sync_speed_min = (int)value;
 		} else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_MAX_RECOVERY_RATE))) {
-			if (test_and_set_bit(__CTR_FLAG_MIN_RECOVERY_RATE, &rs->ctr_flags)) {
+			if (test_and_set_bit(__CTR_FLAG_MAX_RECOVERY_RATE, &rs->ctr_flags)) {
 				rs->ti->error = "Only one max_recovery_rate argument pair allowed";
 				return -EINVAL;
 			}

Original file line number	Diff line number	Diff line change
`@@ -1270,7 +1270,7 @@ static int parse_raid_params(struct raid_set rs, struct dm_arg_set as,`
`1270`	`1270`	`}`
`1271`	`1271`	`rs->md.sync_speed_min = (int)value;`
`1272`	`1272`	`} else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_MAX_RECOVERY_RATE))) {`
`1273`		`- if (test_and_set_bit(__CTR_FLAG_MIN_RECOVERY_RATE, &rs->ctr_flags)) {`
	`1273`	`+ if (test_and_set_bit(__CTR_FLAG_MAX_RECOVERY_RATE, &rs->ctr_flags)) {`
`1274`	`1274`	`rs->ti->error = "Only one max_recovery_rate argument pair allowed";`
`1275`	`1275`	`return -EINVAL;`
`1276`	`1276`	`}`