Skip to content

Commit f1640c3

Browse files
wangweidongdavem330
authored andcommitted
bgmac: fix a missing check for build_skb
when build_skb failed, it may occure a NULL pointer. So add a 'NULL check' for it. Signed-off-by: Weidong Wang <wangweidong1@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ddb5388 commit f1640c3

File tree

1 file changed

+5
-0
lines changed
  • drivers/net/ethernet/broadcom

1 file changed

+5
-0
lines changed

drivers/net/ethernet/broadcom/bgmac.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -466,6 +466,11 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
466466
len -= ETH_FCS_LEN;
467467

468468
skb = build_skb(buf, BGMAC_RX_ALLOC_SIZE);
469+
if (unlikely(skb)) {
470+
bgmac_err(bgmac, "build_skb failed\n");
471+
put_page(virt_to_head_page(buf));
472+
break;
473+
}
469474
skb_put(skb, BGMAC_RX_FRAME_OFFSET +
470475
BGMAC_RX_BUF_OFFSET + len);
471476
skb_pull(skb, BGMAC_RX_FRAME_OFFSET +

0 commit comments

Comments
 (0)