usb: u132-hcd: fix resource leak

Mukesh Ojha · gregkh · commit f276e002793c · 2019-03-28T00:08:49.000+09:00
if platform_driver_register fails, cleanup the allocated resource
gracefully.

Signed-off-by: Mukesh Ojha &lt;mojha@codeaurora.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c
@@ -3204,6 +3204,9 @@ static int __init u132_hcd_init(void)
 	printk(KERN_INFO "driver %s\n", hcd_name);
 	workqueue = create_singlethread_workqueue("u132");
 	retval = platform_driver_register(&u132_platform_driver);
+	if (retval)
+		destroy_workqueue(workqueue);
+
 	return retval;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3204,6 +3204,9 @@ static int __init u132_hcd_init(void)`
`3204`	`3204`	`printk(KERN_INFO "driver %s\n", hcd_name);`
`3205`	`3205`	`workqueue = create_singlethread_workqueue("u132");`
`3206`	`3206`	`retval = platform_driver_register(&u132_platform_driver);`
	`3207`	`+ if (retval)`
	`3208`	`+ destroy_workqueue(workqueue);`
	`3209`	`+`
`3207`	`3210`	`return retval;`
`3208`	`3211`	`}`
`3209`	`3212`