Skip to content

Commit f29200c

Browse files
loysollivierkhilman
loysollivier
authored and
khilman
committed
arm64: dts: meson: Fix mmc cd-gpios polarity
Commit 89a5e15 ("gpio/mmc/of: Respect polarity in the device tree") changed the behavior of "cd-inverted" to follow the device tree bindings specification: According to SDHCI standard, CD lines are specified as "active low". Using the "cd-inverted" property means that the CD line is "active high". Fix the SD card description for meson by setting the cd-gpios as "active low", according to the boards specifications, and dropping the "cd-inverted" property. Fixes: 89a5e15 ("gpio/mmc/of: Respect polarity in the device tree") Signed-off-by: Loys Ollivier <lollivier@baylibre.com> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
1 parent 8615f55 commit f29200c

14 files changed

+14
-28
lines changed

‎arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,7 @@
187187
max-frequency = <100000000>;
188188
disable-wp;
189189

190-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
191-
cd-inverted;
190+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
192191

193192
vmmc-supply = <&vddao_3v3>;
194193
vqmmc-supply = <&vddio_boot>;

‎arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,8 +305,7 @@
305305
max-frequency = <200000000>;
306306
disable-wp;
307307

308-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
309-
cd-inverted;
308+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
310309

311310
vmmc-supply = <&vddio_ao3v3>;
312311
vqmmc-supply = <&vddio_tf>;

‎arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,7 @@
238238
max-frequency = <100000000>;
239239
disable-wp;
240240

241-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
242-
cd-inverted;
241+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
243242

244243
vmmc-supply = <&vddao_3v3>;
245244
vqmmc-supply = <&vddio_card>;

‎arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,7 @@
258258
max-frequency = <100000000>;
259259
disable-wp;
260260

261-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
262-
cd-inverted;
261+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
263262

264263
vmmc-supply = <&tflash_vdd>;
265264
vqmmc-supply = <&tf_io>;

‎arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,7 @@
196196
max-frequency = <100000000>;
197197
disable-wp;
198198

199-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
200-
cd-inverted;
199+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
201200

202201
vmmc-supply = <&vddao_3v3>;
203202
vqmmc-supply = <&vddio_card>;

‎arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,7 @@
154154
max-frequency = <100000000>;
155155
disable-wp;
156156

157-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
158-
cd-inverted;
157+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
159158

160159
vmmc-supply = <&vcc_3v3>;
161160
};

‎arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,8 +211,7 @@
211211
max-frequency = <100000000>;
212212
disable-wp;
213213

214-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
215-
cd-inverted;
214+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
216215

217216
vmmc-supply = <&vddao_3v3>;
218217
vqmmc-supply = <&vcc_3v3>;

‎arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,7 @@
131131
max-frequency = <100000000>;
132132
disable-wp;
133133

134-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
135-
cd-inverted;
134+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
136135

137136
vmmc-supply = <&vddao_3v3>;
138137
vqmmc-supply = <&vddio_card>;

‎arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,7 @@
238238
max-frequency = <100000000>;
239239
disable-wp;
240240

241-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
242-
cd-inverted;
241+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
243242

244243
vmmc-supply = <&vcc_3v3>;
245244
vqmmc-supply = <&vcc_card>;

‎arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,7 @@
183183
max-frequency = <100000000>;
184184
disable-wp;
185185

186-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
187-
cd-inverted;
186+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
188187

189188
vmmc-supply = <&vddao_3v3>;
190189
vqmmc-supply = <&vddio_card>;

‎arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtsi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,7 @@
137137
max-frequency = <100000000>;
138138
disable-wp;
139139

140-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
141-
cd-inverted;
140+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
142141

143142
vmmc-supply = <&vddao_3v3>;
144143
vqmmc-supply = <&vddio_boot>;

‎arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -356,8 +356,7 @@
356356
max-frequency = <100000000>;
357357
disable-wp;
358358

359-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
360-
cd-inverted;
359+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
361360

362361
vmmc-supply = <&vddao_3v3>;
363362
vqmmc-supply = <&vddio_boot>;

‎arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,7 @@
147147
max-frequency = <100000000>;
148148
disable-wp;
149149

150-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
151-
cd-inverted;
150+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
152151

153152
vmmc-supply = <&vddao_3v3>;
154153
vqmmc-supply = <&vddio_boot>;

‎arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,7 @@
170170
max-frequency = <100000000>;
171171
disable-wp;
172172

173-
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
174-
cd-inverted;
173+
cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
175174

176175
vmmc-supply = <&vddao_3v3>;
177176
vqmmc-supply = <&vddio_boot>;

0 commit comments

Comments
 (0)