x86: check function status in EDD boot code

Jan Beulich · H. Peter Anvin · commit f2ba93929fdb · 2008-07-18T14:33:17.000-07:00
Without checking the return value of get_edd_info() and adding the
entry only in the success case, 6 devices show up under
/sys/firmware/edd/, no matter how many devices are actually present.

Signed-off-by: Jan Beulich &lt;jbeulich@novell.com&gt;
Signed-off-by: H. Peter Anvin &lt;hpa@zytor.com&gt;
diff --git a/arch/x86/boot/edd.c b/arch/x86/boot/edd.c
@@ -167,9 +167,8 @@ void query_edd(void)
 		 * Scan the BIOS-supported hard disks and query EDD
 		 * information...
 		 */
-		get_edd_info(devno, &ei);
-
-		if (boot_params.eddbuf_entries < EDDMAXNR) {
+		if (!get_edd_info(devno, &ei)
+		    && boot_params.eddbuf_entries < EDDMAXNR) {
 			memcpy(edp, &ei, sizeof ei);
 			edp++;
 			boot_params.eddbuf_entries++;
