Skip to content

Commit f2dace5

Browse files
ndreysMarc Zyngier
authored andcommitted
irqchip/irq-imx-gpcv2: Make use of BIT() macro
Convert all instances of 1 << x to BIT(x) for consistency with other kernel code. Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: cphealy@gmail.com Cc: l.stach@pengutronix.de Cc: Leonard Crestez <leonard.crestez@nxp.com> Cc: "A.s. Dong" <aisheng.dong@nxp.com> Cc: Richard Zhu <hongxing.zhu@nxp.com> Cc: linux-imx@nxp.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
1 parent bd654fb commit f2dace5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/irqchip/irq-imx-gpcv2.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ static int imx_gpcv2_irq_set_wake(struct irq_data *d, unsigned int on)
7878
u32 mask, val;
7979

8080
raw_spin_lock_irqsave(&cd->rlock, flags);
81-
mask = 1 << d->hwirq % 32;
81+
mask = BIT(d->hwirq % 32);
8282
val = cd->wakeup_sources[idx];
8383

8484
cd->wakeup_sources[idx] = on ? (val & ~mask) : (val | mask);
@@ -101,7 +101,7 @@ static void imx_gpcv2_irq_unmask(struct irq_data *d)
101101
raw_spin_lock(&cd->rlock);
102102
reg = gpcv2_idx_to_reg(cd, d->hwirq / 32);
103103
val = readl_relaxed(reg);
104-
val &= ~(1 << d->hwirq % 32);
104+
val &= ~BIT(d->hwirq % 32);
105105
writel_relaxed(val, reg);
106106
raw_spin_unlock(&cd->rlock);
107107

@@ -117,7 +117,7 @@ static void imx_gpcv2_irq_mask(struct irq_data *d)
117117
raw_spin_lock(&cd->rlock);
118118
reg = gpcv2_idx_to_reg(cd, d->hwirq / 32);
119119
val = readl_relaxed(reg);
120-
val |= 1 << (d->hwirq % 32);
120+
val |= BIT(d->hwirq % 32);
121121
writel_relaxed(val, reg);
122122
raw_spin_unlock(&cd->rlock);
123123

0 commit comments

Comments
 (0)