x86/LDT: Avoid warning in 32-bit builds with older gcc

jbeulich · Ingo Molnar · commit f2f18b16c779 · 2018-02-20T09:33:40.000+01:00
BUG() doesn't always imply "no return", and hence should be followed by a return statement even if that's obviously (to a human) unreachable. Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Thomas Gleixner <tglx@linutronix.de> Cc: Andy Lutomirski <luto@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/5A8AF2AA02000078001A91E9@prv-mh.provo.novell.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h
@@ -74,6 +74,7 @@ static inline void *ldt_slot_va(int slot)
 	return (void *)(LDT_BASE_ADDR + LDT_SLOT_STRIDE * slot);
 #else
 	BUG();
+	return (void *)fix_to_virt(FIX_HOLE);
 #endif
 }
 

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ static inline void *ldt_slot_va(int slot)`
`74`	`74`	`return (void )(LDT_BASE_ADDR + LDT_SLOT_STRIDE slot);`
`75`	`75`	`#else`
`76`	`76`	`BUG();`
	`77`	`+ return (void *)fix_to_virt(FIX_HOLE);`
`77`	`78`	`#endif`
`78`	`79`	`}`
`79`	`80`