Skip to content

Commit f2f2c8b

Browse files
Jiri Pirkodavem330
authored andcommitted
virtio_net: use IFF_LIVE_ADDR_CHANGE priv_flag
Acked-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent bb35f67 commit f2f2c8b

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

drivers/net/virtio_net.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -679,12 +679,11 @@ static int virtnet_set_mac_address(struct net_device *dev, void *p)
679679
{
680680
struct virtnet_info *vi = netdev_priv(dev);
681681
struct virtio_device *vdev = vi->vdev;
682-
struct sockaddr *addr = p;
682+
int ret;
683683

684-
if (!is_valid_ether_addr(addr->sa_data))
685-
return -EADDRNOTAVAIL;
686-
memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
687-
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
684+
ret = eth_mac_addr(dev, p);
685+
if (ret)
686+
return ret;
688687

689688
if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC))
690689
vdev->config->set(vdev, offsetof(struct virtio_net_config, mac),
@@ -1063,7 +1062,7 @@ static int virtnet_probe(struct virtio_device *vdev)
10631062
return -ENOMEM;
10641063

10651064
/* Set up network device as normal. */
1066-
dev->priv_flags |= IFF_UNICAST_FLT;
1065+
dev->priv_flags |= IFF_UNICAST_FLT | IFF_LIVE_ADDR_CHANGE;
10671066
dev->netdev_ops = &virtnet_netdev;
10681067
dev->features = NETIF_F_HIGHDMA;
10691068

0 commit comments

Comments
 (0)